WIP: Batching #1570
WIP: Batching #1570
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| dangling = true | ||
| intra += innerTxnTreeSize(&payset[index].SignedTxnWithAD) | ||
| index++ | ||
| if intra >= leftIntra + batchMinSize { |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
| return nil | ||
| } | ||
|
|
||
| type IndexAndIntra struct { |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
exported: exported type IndexAndIntra should have comment or be unexported (revive)
| // // st := time.Now() | ||
| // // errs0 = loadTransactionsW(db, size, &block) | ||
| // // db.log.Infof("Round %d AddTransactions(total): %d", vb.Block.Round, time.Since(st).Microseconds()) | ||
| // } else |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
| } | ||
|
|
||
| cr := &CountingReader{r: reader} | ||
| var cb types.BlockData |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
undefined: types.BlockData) (typecheck)
| } | ||
|
|
||
| cr := &CountingReader{r: reader} | ||
| var cb types.BlockData |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
undefined: types.BlockData) (typecheck)
| // // db.log.Infof("Round %d AddTransactions(total): %d", vb.Block.Round, time.Since(st).Microseconds()) | ||
| // } else | ||
| // if useExperimentalWithIntraBugfix { | ||
| st := time.Now() |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
|
|
||
| // if useExperimentalTxnInsertion || useExperimentalWithIntraBugfix { | ||
| // if useExperimentalWithIntraBugfix { | ||
| for _, errItem := range errs0 { |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
| return SetupGnomockPgWithVersion(t, "13-alpine") | ||
| } | ||
|
|
||
| func SetupGnomockPgWithVersion(t testing.TB, pgImage string) (*pgxpool.Pool, string, func()) { |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
exported: exported function SetupGnomockPgWithVersion should have comment or be unexported (revive)
| // if maxConns != nil { | ||
| // config.MaxConns = *maxConns | ||
| // } | ||
|
|
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
| }, cr.n, nil | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
idb/postgres/postgres.go
Outdated
| return openPostgres(db, opts, log) | ||
| if tuning == nil { | ||
| tuning = &TuningParams{ | ||
| PgxOpts: serializable, |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
| // TODO: change this to pgs.ReadCommitted | ||
| // var uncommitted = pgx.TxOptions{IsoLevel: pgx.ReadUncommitted} | ||
|
|
||
|
|
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
| } | ||
|
|
||
| // defaultTuningParams returns a TuningParams object with default values. | ||
| func defaultTuningParams() TuningParams{ |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
| default: | ||
| return fmt.Sprintf("unknown_%s", isoLevel) | ||
| } | ||
| } |
There was a problem hiding this comment.
🚫 [Lint Errors] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default -s prefix(github.com/algorand) -s prefix(github.com/algorand/go-algorand) (gci)
Working off a local branch as it's bit easier to test with it.